search

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle
19 stars 20 forks source link

Enable teachers to use the share forum feature #15

Closed nadavkav closed 10 years ago

nadavkav commented 10 years ago

I was asked by teachers to be able to share forums on their own (They have meta courses and courses and they would like to use the same forum in all sub courses)

So I was looking at the code and saw it is not possible to give them a capability that allows them to share forums on their own: if ($CFG->forumng_enableadvanced && has_capability('moodle/site:config', $coursecontext)) {

What is the reason behind it?

jason-platts commented 10 years ago

I guess because a shared forum is available across the whole site and so requires 'more' than being able to create a forum on the current course.

I think that sort of makes sense, but I don't think checking moodle/site:config does.

Perhaps it should be checking mod/forumng:addinstance capability at system level? (I don't really want to create another capability, it makes sense to me that if you can add a forumng on any course then you can 'share' your forum with any course) Does that work for you? (I think it works for us, I need to check...)

nadavkav commented 10 years ago

Great. I did not see any major concern either.

mod/forumng:addinstance capability works fine for us.

jason-platts commented 10 years ago

Fixed: https://github.com/moodleou/moodle-mod_forumng/commit/13416fca4888ec6b275a635cc8863dc05ccc3976