Migrate add_to_log() to events

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle

19 stars 20 forks source link

Migrate add_to_log() to events #30

Closed nadavkav closed 10 years ago

nadavkav commented 10 years ago

This one is trivial :smile: , just posting to get status feedback and see if you already started implementing (or should I start?)

add_to_log() has been deprecated, please rewrite your code to the new events API
line 48 of /lib/deprecatedlib.php: call to debugging()
line 1620 of /mod/forumng/mod_forumng_discussion.php: call to add_to_log()
line 114 of /mod/forumng/discuss.php: call to mod_forumng_discussion->log()

nadavkav commented 10 years ago

BTW, I am using MOODLE_26_STABLE + minor tweaks to make to plugin work

jason-platts commented 10 years ago

We're going to start migrating log calls in all our plugins to the new events based method in August.

nadavkav commented 10 years ago

Great!

( for fun... I have only migrated 3 calls and used the object->log() function with a switch/case inside the log() method. Hope I am on the right track and that is what you are also planning )

jason-platts commented 10 years ago

This is now in master

https://github.com/moodleou/moodle-mod_forumng/commit/875210a962a6471bba1302fc1059f35b977fcf7c

nadavkav commented 10 years ago

Sweeeeeet :smile: