search

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle
19 stars 20 forks source link

Replying from Mobile devices the editor is partially hidden. #36

Open aspark21 opened 9 years ago

aspark21 commented 9 years ago

Moodle 2.7.2 build 20141002 / ForumNG version: latest master Theme based on clean / bootstrapbase

The editing box is partially hidden when replying to a forumNG post inline from an iOS or Android device.

This all seems to be based on the user-agent as desktop browser versions with a desktop UA displays correctly, whereas desktop browser versions with a Mobile UA get the issue. See attached screenshots.

desktop safari with iphone user agent desktop-safari-with-iphone-user-agent

desktop safari desktop-safari

Can this be fixed in the plugin or does it need to be fixed in the renderers of Moodle core?

jason-platts commented 9 years ago

Phone size devices or tablets?

I think the main issue here is that because we don't run a bootstrap theme there are probably going to be problems when viewing in small windows or on small devices, especially as there are some javascript hacks implemented to make forumng work on mobile OS in the old themes.

I'll have a look, there may be something that you can put in your theme to fix it or it may be more terminal!

Unfortunately we don't have any schedule for moving to bootstrap, so this type of problem is going to keep cropping up until we do.

aspark21 commented 9 years ago

Hi Jason,

Screenshots are for phone size in portrait mode, seems to be ok in landscape.

Seems ok on the iPad in portrait size so I'm guessing most tablets (maybe not the phablets) should be ok.

Figured we might have to fix it in our themes for the time being but it also occurred in clean which is the new default with Moodle HQ having removed all other themes from core. So most using this plugin will likely be affected as most institutions are making / have already made the switch.