search

moodleou / moodle-mod_forumng

ForumNG forum module for Moodle
19 stars 20 forks source link

Force Subscribe Doesn't subscribe most users #37

Closed aspark21 closed 9 years ago

aspark21 commented 9 years ago

Moodle 2.7.2 - Build 20141017 - latest MOODLE_27_STABLE DB: MariaDB / MySQL ForumNG version 2014090900 - 2.7 r1 - latest master

Setting the Subscription option to "Force everyone to be subscribed" when creating a ForumNG only subscribes a single user. screen shot 2014-10-22 at 15 13 04

Everyone else enrolled as student or teacher in the course do not get subscribed screen shot 2014-10-22 at 15 13 23

Though somehow when an account which is not subscribed accesses the forum, it tells them they are

screen shot 2014-10-22 at 15 16 10

Emails are only sent to the users listed in the first screenshot.

I can't see a way of manually subscribing other people which doesn't help mitigating the issue in the meantime.

jason-platts commented 9 years ago

Thanks, I'll look into this. There is a unit test for this functionality and it seems to pass - but then it does test on a course with only 1 user enrolled... I had a quick look over the code for auto subscription and can't see any obvious mistakes - but then we don't use this functionality so there may well be an issue that hasn't been spotted, especially on 2.7 as we are not live on that yet.

Just to confirm, your main forum plugin config setting for subscription remains at "Configured separately for each forum"?

aspark21 commented 9 years ago

Hi Jason, Yes it uses " Configured separately for each forum" at site level.

I believe we also have the issue on a Moodle 2.6.2 site (20140310) but it's on an older version of the plugin (2014013002) and has a bunch of custom roles so I figured I would try and eliminate those sources of potential conflicts in the testing.

jason-platts commented 9 years ago

I've hopefully fixed this as there was a sql error when retrieving the forced subscribers.

It will be in MASTER and 2.7 version - you might be able to cherry-pick to 2.6 version.

Change will be upstream soon.

jason-platts commented 9 years ago

https://github.com/moodleou/moodle-mod_forumng/commit/7cd4748485ac2111f4affd2f9fa2c78a045bd01f

https://github.com/moodleou/moodle-mod_forumng/commit/8b0be806f919242a9b3191f7ddc55538ab27645f

Hopefully these two commits fix this issue.

aspark21 commented 9 years ago

Yes it does definitely. Been having to go through a lot of forums to correct settings as emails started flooding back. :)

Thanks Jason!! Much appreciated.