moodleou / moodle-mod_openstudio

Open Studio Moodle mod plugin
GNU General Public License v3.0
7 stars 3 forks source link

Breaks Dropdown menus #4

Open aspark21 opened 4 years ago

aspark21 commented 4 years ago

Openstudio: latest master Moodle: 3.7.7 and 3.9.1 Other plugins on site: Blackboard Ally set (https://github.com/blackboard-open-source/moodle-tool_ally#additional-plugins) & Adaptable theme (https://gitlab.com/jezhops/moodle-theme_adaptable)

After a couple of misfires with identifying the source of this issue, we are now confident that OpenStudio is the culprit.

What's broken:

This seems like what #2 reported but which was lacking detail.

We have been testing a lot of different plugins for start of academic year and the most noticeable impact this was having was javascript errors with Blackboard Ally, which we reported as https://github.com/blackboard-open-source/moodle-tool_ally/issues/45 which affected the site admin menus , however the "Edit" dropdowns were still broken after removing Ally.

We now have a fully working build with all the other plugins now that we've removed OpenStudio.

Not particularly familiar with how to debug Javascript errors, if there is any test you want us to run happy to, but I've listed repos above for some of the plugins which might be involved in the JS conflicts.

jason-platts commented 4 years ago

Interesting.. thanks for the detailed report. Unfortunately I've been unable to replicate the issue. I have downloaded Adaptable 2.2.2 and running on 3.8.4 all the issues you mentioned are not present for me (I tested Adaptable, Boost and Classic themes). There may be issues with the Ally plugins mentioned, or maybe something specific to the configuration you have setup.

It is worth checking the browser console (F12 key) for reported errors either on page load or when attempting the action that is not working, that sometimes helps narrow down where there are issues. Generally the Open Studio javascript would not run on other pages, so if it were causing an issue it would be in the source code where all the javascript is compressed into a single file (OS also uses some third party libraries so they could be causing issues on your setup).