search

moodleou / moodle-mod_ouwiki

Alternative wiki module for Moodle 2 (designed for use in teaching and learning)
36 stars 32 forks source link

Annotation Issue - Students unable to annotate other students wiki #26

Closed mfindlayated closed 10 years ago

mfindlayated commented 10 years ago

Hi,

One of our courses has a requirement that students should be able to annotate other students wiki pages.

When you switch on "mod/ouwiki:annotate" either in the Activity settings, or even as high up as the Student role, the student can add annotations to their own wiki pages, but not other pages.

Best wishes, Mark.

jason-platts commented 10 years ago

I can't seem to be able to replicate this issue.

Have you tried as a user with admin rights? If it works for them that usually suggests it is a permissions/role issue.

mfindlayated commented 10 years ago

OK, I have installed the newest version of v2.4 on my local sandbox, and still get the same behaviour. Here is what I am doing in more detail.

Create OU Wiki with the following settings..

wiki_settings

Then go to OU wiki admin > Permissions and set as following (more permissions than necessary)...

permissions

Go to wiki as admin, can annotate students wiki pages as expected...

as_admin

Go to wiki as student, can annotate my wiki page as expected...

student1_own

But when I try to annotate another student's wiki page, the annotate links/tab have gone...

student1_otherstudent

?

Thanks again, Mark

jason-platts commented 10 years ago

OK thanks for the info, I can see the issue now.

So looking at the code it actually doesn't support this functionality - if you view someone else's wiki it only allows you to edit or annotate if you have access all groups capability (moodle/site:accessallgroups) locallib.php ouwiki_set_extra_subwiki_fields().

The only way I can see to fix this would be to have a new capability to control ability to add annotations to other people's wiki - as you might have a situation where you didn't want this (in fact to match the view capability we would probably need two - one for annotate all and one for annotate in same group!).

I'll look into this for our upcoming (Dec) 2.5 release if we have time.

So for now you could just give accessallgroups to students for that wiki - I don't think that would have any unintended side-effects (as you are not using group mode for the activity) but obviously would need to be tested.

mfindlayated commented 10 years ago

Hi Jason, thanks for looking at this, we have found a setting which will allow this activity to happen (ironically, about the only setting I hadn't enabled!). The setting which enables the annotate tab is: OU wiki admin > Permissions > Course > give Access all groups

Thanks again, Mark.

mfindlayated commented 10 years ago

A yes, should have read all of your comment! ;)

Thanks this functionality as standard would be really good....

jason-platts commented 10 years ago

Glad the all groups is working for you.

I've reopened this issue as that is a work-around, not a fix - so ideally this should be supported in the code.

jason-platts commented 10 years ago

This is now fixed ready for the 2.6 release in Dec.

I have added two new capabilities:

mod/ouwiki:editothers

and

mod/ouwiki:annotateothers

If you have either these or access all groups (to retain current functionality) then you can edit/annotate other wikis. You can only do this if you have permission to view the wiki (so this capability is secondary to that).