search

moodleou / moodle-mod_ouwiki

Alternative wiki module for Moodle 2 (designed for use in teaching and learning)
36 stars 32 forks source link

Hebrew page names break url in add_to_log (ouwiki view) #5

Closed nadavkav closed 12 years ago

nadavkav commented 12 years ago

Hebrew page names breaks the $url in ouwiki_print_footer (line 984) $url .= '&page='.urlencode($pagename);

When i use : $url .='&page='.htmlentities($pagename);

It works fine :-)

sammarshallou commented 12 years ago

Your suggested change is incorrect. The URL should be URL-encoded, not HTML-encoded.

I just tried with a Japanese page name (cannot type hebrew but as Unicode text it should be the same) and confirmed:

  1. No errors in print_footer
  2. If I copy/paste that url from log table in database, into my browser, it works.

so I don't think there is a problem here? Closing issue, can reopen if there is more explanation or something...

nadavkav commented 12 years ago

Sam, I know you are perfectly right, technically, but still... that funny htmlentities() function "solved" this issue for me. Thanks :-)