moodleou / moodle-mod_ouwiki

Alternative wiki module for Moodle 2 (designed for use in teaching and learning)
36 stars 32 forks source link

You have declared one of ouwiki_grade_item_update and ouwiki_update_grades but not both. This will cause broken behaviour. #82

Open dsoini opened 5 years ago

dsoini commented 5 years ago

Saw broken gradebook behavior in moodle 3.5 in a course. Steps to produce the broken behavior:

A course with multiple kinds of activities.

  1. Delete an Ouwiki activity.
  2. Note that gradebook displays a warning "Warning: Activity deletion in progress! Some grades are about to be removed. " and next to the item [Deletion in progress].
  3. Try to delete other types of activites. Notes that they, too, display [Deletion in progress'.
  4. Add the missing function (ouwiki_update_grades) to its lib.php.
  5. The broken gradebook behavior in the existing course does not go away, but if you start over with a duplicate of the course, the issue is not reproduced.
dsoini commented 5 years ago

Hello, here is code we have used to fix the broken behavior described above.

` /**

/**