search

moodleou / moodle-mod_subpage

Subpage module allows you to add Moodle activities onto inner page within course
21 stars 15 forks source link

incorrect requirement #21

Closed pavelsokolov closed 4 years ago

pavelsokolov commented 4 years ago

There's no 'sharedsubpage', while it's required. This is simply incorrect, since it assumes there's another copy of the subpage plugin.

https://github.com/moodleou/moodle-mod_subpage/blob/a5d0c470ea782f8efffa1997785f018f48f197d7/renderer.php#L27

sammarshallou commented 4 years ago

Ugh, who did that (don't answer that, I can see it and I know who the guilty part is). You're right, this is a bug - there shouldn't be a reference to that module which is not public.

sammarshallou commented 4 years ago

OK - I have fixed this and the fix is now in the 'master' and MOODLE_36_STABLE, MOODLE_35_STABLE github branches. For technical reasons it's not in MOODLE_37_STABLE yet, hopefully we will get that one updated soon (feel free to add a comment here if we forget). Please check it out using the new code and hopefully it works now, or at least won't fail for that reason...