search

moodleou / moodle-mod_subpage

Subpage module allows you to add Moodle activities onto inner page within course
21 stars 15 forks source link

Edit Menu #8

Open belindacaulfield opened 9 years ago

belindacaulfield commented 9 years ago

Hi We are using Subpage2.3+ and Moodle 2.6.5, We are having problems with subpage, when you add a document the edit menu appears to the right of the file, but when you go back into the subpage the edit menus disappear and one edit menu is visible at the top right of the screen.
subpage error

I noticed that it indents the document when you go back into the subpage to view the documents.

We have tried various themes and the result is the same, we did not have this problem in Moodle 2.5.

Thanks

Belinda

sammarshallou commented 9 years ago

First please could you ensure you're using the latest subpage version for Moodle 2.6 (from our MOODLE_26_STABLE branch on github)?

I think the version number for subpage (in mod/subpage/version.php) should be 2014012000.

If you confirm that you're using this version and it's still broken, I'll have a think - we don't currently use the 'new-style' activity edit dropdown menus in our theme so it's possible something might be broken with those, although I think it's working in the 2.7 version.

--sam

sam marshall Leading Technical Developer Information Technology Berrill Level 2

(01908) 655673 Study with the OU :: www.open.ac.uk

-----Original Message----- From: belindacaulfield [mailto:notifications@github.com] Sent: 22 September 2014 10:33 To: moodleou/moodle-mod_subpage Subject: [moodle-mod_subpage] Edit Menu (#8)

Hi We are using Subpage2.3+ and Moodle 2.6.5, We are having problems with subpage, when you add a document the edit menu appears to the right of the file, but when you go back into the subpage the edit menus disappear and one edit menu is visible at the top right of the screen.

subpage error https://cloud.githubusercontent.com/assets/8859050/4354104/fe884bac- 423a-11e4-8cab-7c4997986e35.PNG

I noticed that it indents the document when you go back into the subpage to view the documents.

We have tried various themes and the result is the same, we did not have this problem in Moodle 2.5.

Thanks

Belinda

— Reply to this email directly or view it on GitHub https://github.com/moodleou/moodle-mod_subpage/issues/8 . https://github.com/notifications/beacon/68663__eyJzY29wZSI6Ik5ld3NpZX M6QmVhY29uIiwiZXhwaXJlcyI6MTcyNjk5NzU2MywiZGF0YSI6eyJpZCI6NDMy MjM4MDF9fQ==--755ee6cb8f2d052f50625bb1aaed6027294c3f4f.gif

-- The Open University is incorporated by Royal Charter (RC 000391), an exempt charity in England & Wales and a charity registered in Scotland (SC 038302). The Open University is authorised and regulated by the Financial Conduct Authority.

belindacaulfield commented 9 years ago

Hi Sam, I had tried to upgrade to the new version but when I try to add a new subpage to the topic and select save and display, I get a blank screen so I am unable to edit the page ☹

Belinda

Belinda Caulfield ILT Developer/ Datblygiad TDG Coleg y Cymoedd Tel/Ffon: 01443 810190 / ext: 4218 E-mail/E-bost: Belinda.Caulfield@cymoedd.ac.ukmailto:Belinda.Caulfield@cymoedd.ac.uk

From: sam marshall [mailto:notifications@github.com] Sent: 22 September 2014 10:50 To: moodleou/moodle-mod_subpage Cc: Belinda Caulfield Subject: Re: [moodle-mod_subpage] Edit Menu (#8)

First please could you ensure you're using the latest subpage version for Moodle 2.6 (from our MOODLE_26_STABLE branch on github)?

I think the version number for subpage (in mod/subpage/version.php) should be 2014012000.

If you confirm that you're using this version and it's still broken, I'll have a think - we don't currently use the 'new-style' activity edit dropdown menus in our theme so it's possible something might be broken with those, although I think it's working in the 2.7 version.

--sam

sam marshall Leading Technical Developer Information Technology Berrill Level 2

(01908) 655673 Study with the OU :: www.open.ac.uk

-----Original Message----- From: belindacaulfield [mailto:notifications@github.com] Sent: 22 September 2014 10:33 To: moodleou/moodle-mod_subpage Subject: [moodle-mod_subpage] Edit Menu (#8)

Hi We are using Subpage2.3+ and Moodle 2.6.5, We are having problems with subpage, when you add a document the edit menu appears to the right of the file, but when you go back into the subpage the edit menus disappear and one edit menu is visible at the top right of the screen.

subpage error https://cloud.githubusercontent.com/assets/8859050/4354104/fe884bac- 423a-11e4-8cab-7c4997986e35.PNG

I noticed that it indents the document when you go back into the subpage to view the documents.

We have tried various themes and the result is the same, we did not have this problem in Moodle 2.5.

Thanks

Belinda

— Reply to this email directly or view it on GitHub https://github.com/moodleou/moodle-mod_subpage/issues/8 . https://github.com/notifications/beacon/68663__eyJzY29wZSI6Ik5ld3NpZX M6QmVhY29uIiwiZXhwaXJlcyI6MTcyNjk5NzU2MywiZGF0YSI6eyJpZCI6NDMy MjM4MDF9fQ==--755ee6cb8f2d052f50625bb1aaed6027294c3f4f.gif

-- The Open University is incorporated by Royal Charter (RC 000391), an exempt charity in England & Wales and a charity registered in Scotland (SC 038302). The Open University is authorised and regulated by the Financial Conduct Authority.

— Reply to this email directly or view it on GitHubhttps://github.com/moodleou/moodle-mod_subpage/issues/8#issuecomment-56351236.

belindacaulfield commented 9 years ago

Hi Sam, I have checked our version and it is 2014012000 on Moodle 2.6.5, this is what happens when you go into a subpage and try to edit or add a new resource:

[Edit options when adding a new resource to an existing subpage But when you return to your course and go back into the subpage the new resource displays the same as the ones above. If you Click on the top edit, and save and return to course all the edit options appear next to the resource][Edit options when created subpage][cid:image013.png@01CFD65E.E57650C0][cid:image015.png@01CFD65E.E57650C0][cid:image017.png@01CFD65E.E57650C0][cid:image018.jpg@01CFD65E.E57650C0]

[cid:image019.png@01CFD65E.E57650C0][cid:image020.png@01CFD65E.E57650C0] but when you go back to the course and enter the subpage again it only shows the edit at the top right of the screen.

Kind Regards,

Belinda

Belinda Caulfield ILT Developer/ Datblygiad TDG Coleg y Cymoedd Tel/Ffon: 01443 810190 / ext: 4218 E-mail/E-bost: Belinda.Caulfield@cymoedd.ac.ukmailto:Belinda.Caulfield@cymoedd.ac.uk

From: sam marshall [mailto:notifications@github.com] Sent: 22 September 2014 10:50 To: moodleou/moodle-mod_subpage Cc: Belinda Caulfield Subject: Re: [moodle-mod_subpage] Edit Menu (#8)

First please could you ensure you're using the latest subpage version for Moodle 2.6 (from our MOODLE_26_STABLE branch on github)?

I think the version number for subpage (in mod/subpage/version.php) should be 2014012000.

If you confirm that you're using this version and it's still broken, I'll have a think - we don't currently use the 'new-style' activity edit dropdown menus in our theme so it's possible something might be broken with those, although I think it's working in the 2.7 version.

--sam

sam marshall Leading Technical Developer Information Technology Berrill Level 2

(01908) 655673 Study with the OU :: www.open.ac.ukhttp://www.open.ac.uk

-----Original Message----- From: belindacaulfield [mailto:notifications@github.com] Sent: 22 September 2014 10:33 To: moodleou/moodle-mod_subpage Subject: [moodle-mod_subpage] Edit Menu (#8)

Hi We are using Subpage2.3+ and Moodle 2.6.5, We are having problems with subpage, when you add a document the edit menu appears to the right of the file, but when you go back into the subpage the edit menus disappear and one edit menu is visible at the top right of the screen.

subpage error https://cloud.githubusercontent.com/assets/8859050/4354104/fe884bac- <https://cloud.githubusercontent.com/assets/8859050/4354104/fe884bac-%20%0b> 423a-11e4-8cab-7c4997986e35.PNG>

I noticed that it indents the document when you go back into the subpage to view the documents.

We have tried various themes and the result is the same, we did not have this problem in Moodle 2.5.

Thanks

Belinda

— Reply to this email directly or view it on GitHub https://github.com/moodleou/moodle-mod_subpage/issues/8 . https://github.com/notifications/beacon/68663__eyJzY29wZSI6Ik5ld3NpZX <https://github.com/notifications/beacon/68663__eyJzY29wZSI6Ik5ld3NpZX%20%0b> M6QmVhY29uIiwiZXhwaXJlcyI6MTcyNjk5NzU2MywiZGF0YSI6eyJpZCI6NDMy MjM4MDF9fQ==--755ee6cb8f2d052f50625bb1aaed6027294c3f4f.gif>

-- The Open University is incorporated by Royal Charter (RC 000391), an exempt charity in England & Wales and a charity registered in Scotland (SC 038302). The Open University is authorised and regulated by the Financial Conduct Authority.

— Reply to this email directly or view it on GitHubhttps://github.com/moodleou/moodle-mod_subpage/issues/8#issuecomment-56351236.

sammarshallou commented 9 years ago

Wow, the email responses thing from github really isn't working at all well (I'm responding to this on the website instead).

Thinking about it, I do recall I did something when I was making it work and adding testing for our 2.7 version which is now available (albeit still a development version) on the master branch of our github. Regarding the edit icons appearing in the wrong place, I think I saw that behaviour, and it is possibly the following CSS file addition that fixed it. You could try applying that same modification to the 2.6 version?

https://github.com/moodleou/moodle-mod_subpage/commit/bd41b98141c070a16e0e7421381b9bc6fb9ba1e8#diff-4e7bb40584b55a44f4657b188986bff4R11

Please let me know if it works.

belindacaulfield commented 9 years ago

Thank you Sam, I will try this tomorrow morning ☺

Belinda

Belinda Caulfield ILT Developer/ Datblygiad TDG Coleg y Cymoedd Tel/Ffon: 01443 810190 / ext: 4218 E-mail/E-bost: Belinda.Caulfield@cymoedd.ac.ukmailto:Belinda.Caulfield@cymoedd.ac.uk

From: sam marshall [mailto:notifications@github.com] Sent: 22 September 2014 14:42 To: moodleou/moodle-mod_subpage Cc: Belinda Caulfield Subject: Re: [moodle-mod_subpage] Edit Menu (#8)

Wow, the email responses thing from github really isn't working at all well (I'm responding to this on the website instead).

Thinking about it, I do recall I did something when I was making it work and adding testing for our 2.7 version which is now available (albeit still a development version) on the master branch of our github. Regarding the edit icons appearing in the wrong place, I think I saw that behaviour, and it is possibly the following CSS file addition that fixed it. You could try applying that same modification to the 2.6 version?

bd41b98#diff-4e7bb40584b55a44f4657b188986bff4R11https://github.com/moodleou/moodle-mod_subpage/commit/bd41b98141c070a16e0e7421381b9bc6fb9ba1e8#diff-4e7bb40584b55a44f4657b188986bff4R11

Please let me know if it works.

— Reply to this email directly or view it on GitHubhttps://github.com/moodleou/moodle-mod_subpage/issues/8#issuecomment-56374027.

belindacaulfield commented 9 years ago

Hi Sam, I tried this but it did not work it just left me with a blank page ☹

Belinda

Belinda Caulfield ILT Developer/ Datblygiad TDG Coleg y Cymoedd Tel/Ffon: 01443 810190 / ext: 4218 E-mail/E-bost: Belinda.Caulfield@cymoedd.ac.ukmailto:Belinda.Caulfield@cymoedd.ac.uk

From: sam marshall [mailto:notifications@github.com] Sent: 22 September 2014 14:42 To: moodleou/moodle-mod_subpage Cc: Belinda Caulfield Subject: Re: [moodle-mod_subpage] Edit Menu (#8)

Wow, the email responses thing from github really isn't working at all well (I'm responding to this on the website instead).

Thinking about it, I do recall I did something when I was making it work and adding testing for our 2.7 version which is now available (albeit still a development version) on the master branch of our github. Regarding the edit icons appearing in the wrong place, I think I saw that behaviour, and it is possibly the following CSS file addition that fixed it. You could try applying that same modification to the 2.6 version?

bd41b98#diff-4e7bb40584b55a44f4657b188986bff4R11https://github.com/moodleou/moodle-mod_subpage/commit/bd41b98141c070a16e0e7421381b9bc6fb9ba1e8#diff-4e7bb40584b55a44f4657b188986bff4R11

Please let me know if it works.

— Reply to this email directly or view it on GitHubhttps://github.com/moodleou/moodle-mod_subpage/issues/8#issuecomment-56374027.

sammarshallou commented 9 years ago

Oh dear. :( OK, I don't really have time to investigate this in more detail, sorry - are you able to work out a fix yourself? Or maybe raise in a suitable discussion forum to see if anyone else has encountered it?