search

moodleou / moodle-qtype_pmatch

Pattern-match question type for Moodle
12 stars 23 forks source link

PHP 7.1+ issues with public const call #41

Closed dustinbrisebois closed 4 years ago

dustinbrisebois commented 5 years ago

Greetings -

PHP appears to have deprecated the use of public const calls within abstract class spaces

the calls here (and below) https://github.com/moodleou/moodle-qtype_pmatch/blob/7c8f08af08194fa3377ceb9b487ce5b427f68beb/classes/local/spell/qtype_pmatch_spell_checker.php#L48

Cause a number of warnings as the scope appears unsupported beyond abstract classes.

timhunt commented 5 years ago

Are you sure? I don't see any warnings caused by this.

dustinbrisebois commented 5 years ago

@timhunt

Yeah I'm pretty sure.

image

dustinbrisebois commented 5 years ago

@timhunt

The next question is -- if you clear out the "public const" calls we get this

image

Which suggests that the get_config line on 70 is empty.

timhunt commented 4 years ago

Fixed in the latest version.