Improvement: please replace language string constants with variables

moodleou / moodle-qtype_pmatch

Pattern-match question type for Moodle

12 stars 23 forks source link

Improvement: please replace language string constants with variables #46

Closed germanvaleroelizondo closed 4 years ago

germanvaleroelizondo commented 5 years ago

Hi,

This improved version is great, but it would be even greater if you replaced the English language constants in the file 'edit_pmatch_form.php' with string variables declared in /lang/ed/qtype_pmatch.php .And they would be available for all AMOS translators.

Thanks in advance

timhunt commented 5 years ago

Doh! sorry. Don't know how that got through code review.

germanvaleroelizondo commented 5 years ago

No worries mate !

germanvaleroelizondo commented 5 years ago

By the way, there seem to be some very nice examples somewhere else ; they would be even nicer if those English language strings were also string variables available in AMOS.

timhunt commented 4 years ago

This should be fixed in the latest version.

germanvaleroelizondo commented 4 years ago

Thanks.