Main branch regression - Githubissues

moodleou / moodle-qtype_pmatch

Pattern-match question type for Moodle

12 stars 23 forks source link

Main branch regression #56

Closed Peterburnett closed 3 years ago

Peterburnett commented 3 years ago

In swapping from master->main, some commits appear to have been dropped.

Eg https://github.com/moodleou/moodle-qtype_pmatch/pull/54 This patch is no longer present on the main branch and unit tests again throw a deprecation notice on PHP 7.4

Peterburnett commented 3 years ago

Hi @timhunt, just a ping, this is causing a bunch of CI noise, and am trying to avoid swapping to a fork for production. Are you able to have a peek at this sometime? Thanks

timhunt commented 3 years ago

Sorry for the delay. I have added that commit back (I think it was the only one lost). Is having it on main enough, or should I push a new release to the plugsin DB?