search

moodleou / moodle-quiz_answersheets

A Moodle quiz report to allow quiz attempts to be exported
8 stars 15 forks source link

Report skeleton that lists students in the quiz, and whether they have an in-progress attempt #1

Closed HuongNV13 closed 4 years ago

HuongNV13 commented 4 years ago

Hi @timhunt,

Please help me to review it

The code was tested done by our tester

Thanks,

timhunt commented 4 years ago

This looks great Huong.

I only spotted two very minor things while reviewing:

  1. In version.php, you should probably set a few more properties (for example like https://github.com/moodleou/moodle-quiz_gradingstudents/blob/master/version.php).
  2. In db/install.php, I think that $record->displayorder should be about '5000'; (after standard Moodle manual grading).

Up to you whether you amend this commit to fix those two things, and them wer merge it, or alternatively we put this in now, and you fix those things in a future comment. Up to you how you want to do it.

HuongNV13 commented 4 years ago

Thanks Tim for your comment,

I already fixed all the points and squash the commits

Please help me to review it again

Thanks,

timhunt commented 4 years ago

Great. thanks.