Closed lamtranb closed 4 years ago
This will fix #9
I was already looking at the patch when Huong's request came throught :-)
Just one general point: When you find your code has a bug like "Cannot create attempt properly if quiz is unlimited", ... well that mistake happened once, so it is clearly the sort of case that can break, and we did not have an automated test to detect it. Therefore, it would be good practice to add a test now, to make sure it never breaks again.
In fact the best practice (if you have time) is:
Anyway, I did not hold up merging this, but something to think about next time.
Hi @timhunt, Thanks for your advice. I will write a behat test to cover this case and make sure it's working as expected in the next commit.
:-) Great thanks.
Fix bugs: