moodleou / moodle-quiz_answersheets

A Moodle quiz report to allow quiz attempts to be exported
8 stars 15 forks source link

Hide responses history and add header when print attempt sheet #12

Closed HuongNV13 closed 4 years ago

HuongNV13 commented 4 years ago

Hi @timhunt,

Please help me to review it

Including in this branch:

The code was tested done by our tester

Thanks,

timhunt commented 4 years ago

Hi Huong. This generally looks good. There is just one thing that I am not sure of.

I am worried that it will confuse uses if in the browser they see review_summary_table but in print they see echo render_attempt_sheet_print_header

Would it be better if we used the same display in both places? (Position: static at the start in the browser, and position: fixed runner header when printing)

Well, I guess for the response sheet, we do want the useful information in the summary table, but only the information that is not in the header.

Does that make sense?

HuongNV13 commented 4 years ago

Thanks for your comment Tim, As Chris want to show the header from the 2nd page onward to prevent the duplicated information from the header and summary table

The header also display in both place

Please help me to review It again

Thanks,

timhunt commented 4 years ago

Thanks Huong. Merged.