Record all actions on quiz report in a log file

moodleou / moodle-quiz_answersheets

A Moodle quiz report to allow quiz attempts to be exported

8 stars 15 forks source link

Record all actions on quiz report in a log file #13

Closed HuongNV13 closed 4 years ago

HuongNV13 commented 4 years ago

Hi @timhunt,

Please help me to review it. The code was tested done by our tester.

Thanks,

timhunt commented 4 years ago

This looks good:

Only one thing I think needs to be fixed. We should validate the page type passed to the create_attempt function, to be sure that we only ever try to create events of the expected types. (Also, it should probably be PARAM_ALPHA, not PARAM_TEXT.
One other comment: when we said "log every action" I did not imagine that you would impelement AJAX code to log when the user preseed print in their browser, but bery cool that you did :-)

HuongNV13 commented 4 years ago

Thanks Tim for your comment, I already changed the param type from PARAM_TEXT to PARAM_ALPHAEXT (because PARAM_ALPHAEXT allow the same contents as PARAMALPHA but also for and - characters.

Also, new code created to validate the page type to only allow accepted events

Please help me to review it

Thanks,

timhunt commented 4 years ago

Thanks Huong. That looks good now. Rebased and merged.