Closed HuongNV13 closed 4 years ago
Thanks Huong this is looking generally very good, but there are some things that are not right yet. (Also, I have commented on some minor coding style things I noticed.)
Thanks for working on this. If any of the above is not clear, I am happy to discuss.
Hi Huong? I can see that you pushed another commit. Does that mean that this is ready for review again?
Also, please could you rebase on latest master? Thanks.
Hi Tim, We are just done the local test again after the fix. Please help me to review it again
About point 12: For in-progress attempt, I will show the summary table with only Fullname. If any information that we need in future, we can change it
Thanks,
Very nearly perfect. I am afraid I spotted two small things that are not quite right.
and
If you can fix those, then this can be merged into master tomorrow (or today, your time!)
I also noticed one more thing, which it might be worth fixing as part of the next task you do. (I think don't do this now because we want to get the current task finished, and it nearly is):
FUTURE. It occurs to me that in modern Moodle coding style, it would be better to put classes like quiz_answersheets_table.php inside the classes folder, so they can be auto-loaded.
In case it is not obvious, I think that the reason 3) is necessary - if you want to verify it in testing, is one of two things:
Handling the attached files will probably break if context is not set.
Hi Tim. Thanks for your comment. I pushed another commit. Please help me to review it again
Thanks,
Great! Thanks Huong.
Hi @timhunt ,
Please help me to review it
The code was tested done by our tester
Thanks,