moodleou / moodle-quiz_answersheets

A Moodle quiz report to allow quiz attempts to be exported
8 stars 15 forks source link

Display a customisable message at the top of the report (e.g. link to policy document) #4

Closed HuongNV13 closed 4 years ago

HuongNV13 commented 4 years ago

Hi @timhunt ,

Please help me to review it

The code was tested done by our tester

Thanks,

timhunt commented 4 years ago

Tl;dr; It is spot on. Thanks.

There was one thing I was worried about:

  1. Since the config setting is user-input HTML, should it be passed thorugh format_text on output?

I tried to examples in core Moodle code, but just ended up getting totally confused:

My guess is that you should do format_text(..., FORMAT_HTML).

However, looking through all the examples in the OU code, we just use the value directly. So I guess your code is consistent with all our other examples, and we should stick with that. Therefore, I will merge this pull request.