search

moodleou / moodle-quiz_answersheets

A Moodle quiz report to allow quiz attempts to be exported
8 stars 15 forks source link

Screen for a staff member to view an answer sheet for an in-progress attempt that prints well #5

Closed HuongNV13 closed 4 years ago

HuongNV13 commented 4 years ago

Hi @timhunt, Please help me to review it

The code was tested done by our tester

Thanks,

timhunt commented 4 years ago

Nice work Huong.

Of course, the key part is https://github.com/moodleou/moodle-quiz_answersheets/commit/d8886da36794fa3c71c331e477043c2485a68d2f#diff-93e0ab1f73f671f32b970fc869267031R66, and that is spot on.

I have merged it into master.

There is one more think that it woudl be good if you could fix in a future commit:

FUTURE: In db/access.php, please add a comment above each capability to explain what the purpose of the capability is (Just like you would add a one-line description using PHPdoc above each function. Here is an example of how it should look: https://github.com/moodleou/moodle-report_embedquestion/blob/master/db/access.php#L30

Thanks,