Closed jwalits closed 3 years ago
We had a long discussion about what to implement, which concluded with the decision to just imlement tokendownload.php. You have now gone and done something different :-(
You have implemented new functionality without writing any automated tests. That is not acceptable.
Please try again. (And, perhaps get an experienced developer at Catalyst to review it before sending it to me.)
This pr does accurately represent what was discussed in the issue with @abias , a WS to create the tokens and a tokendownload script which uses the token. The comment around adding tests is perfectly valid, can you please reopen this this pr and we'll fix that up.
If you were expecting only a tokendownload script then how do you want the tokens to be created and managed instead? Or were you expecting the download script to directly use a WR token and not a user key token?
I've got a better idea @brendanheywood.
Why don't you close the long rambing issue related to this pull request, and start again with a new new issues which concisely describes what you plan to implemented. It needs to be obvious that is a good, easy to maintain, addition to report_customsql.
Your proposal needs to account for:
Apparently @abias is paying you for this feature, but you are just eating seemingly limitless amounts of my time - and I am busy.
Adding a new webservice to pull query results.
Fixes #99