moodleou / moodle-report_customsql

A Moodle report plugin that lets you easily create simple reports that can be expressed as a single SQL query
48 stars 100 forks source link

Fixes for #124 and #126 #127

Closed marxjohnson closed 11 months ago

marxjohnson commented 1 year ago

This fixes #124 by bumping the PostgreSQL version for GitHub actions to 12, so the tests can run on 4.1 and above.

I have fixed #126 by having the custom behat step swap "CHR" for "CHAR" if you're on a MySQL-family database. This seemed the sensible place to do it rather than having 2 separate behat tests. The alternative would be to make the change when the query is saved or executed, meaning it would work when you actually use the plugin too, but I'd expect people will write the flavour of SQL for the database they're actually running on, and if they migrate it's not unreasonable to expect them to update their queries.