search

moodleou / moodle-report_embedquestion

Work in progress. Do not use yet.
1 stars 4 forks source link

backup_questions_attempt_data_trait is not available before Moodle 3.8 #5

Closed gormster closed 4 years ago

gormster commented 4 years ago

Your plugin is listed as being compatible with 3.6+, but causes courses to fail backups in versions before 3.6. Wrapping the backup class in a trait_exists check is not enough - moodle assumes that, if the file exists, a class is defined within it.

To me, the simple thing to do is just backport the trait from 3.8 and include it if it doesn't already exist. I've patched this on my server, it seems to work just fine, but I haven't been able to test it thoroughly.

timhunt commented 4 years ago

This is a duplicate of issue #2. Closing this.