search

moodleou / moodle-tiny_embedquestion

A TinyMCE editor plugin for use with the embed questions filter.
Other
0 stars 1 forks source link

document.getElementById(...) is null #2

Open mudrd8mz opened 5 months ago

mudrd8mz commented 5 months ago
  1. I have a simple true / false question prepared in the course question bank.
  2. ID number defined for both the category and the question.
  3. New Page resource created in the course.
  4. Attempting to embed the question using the Insert > Embedded question menu.
  5. When I select the category and the question
  6. Nothing happens when I press the "Embed question" button
  7. Browser console reports error: Uncaught TypeError: document.getElementById(...) is null

with the line number indicating the line https://github.com/moodleou/moodle-tiny_embedquestion/blob/e0c0809002fb2c43d63b724c9f14ffe7dde1e145/amd/src/dialogue_manager.js#L106

mudrd8mz commented 5 months ago

Using the browser console, I can confirm that when the dialogue window is opened, the id_questionidnumber dropdown menu is found, but id_iframedescription gives null.

timhunt commented 5 months ago

Oh! drat!

This is beacuse I have not got aroudn to pushing the latest filter_embedquestoin code to github.

Sorry to waste your time. I will get that sorted then let you know.

marycooch commented 3 months ago

Great thanks Tim - we will be upgrading Academy on the 10th and we use this plugin heavily.

TomoTsuyuki commented 2 months ago

Hi @timhunt ,

Has the filter_embedquestoin plugin been updated? Is this issue fixed?