Inconsistent handling of HTML tags in topic and knowledge

moodlepeers / moodle-mod_groupformation

Formation of optimized learning groups - by topic preference or best match of individuals' characteristics and preferences; in one easy to use Moodle acticity

GNU General Public License v3.0

6 stars 5 forks source link

Inconsistent handling of HTML tags in topic and knowledge #24

Closed mudrd8mz closed 7 years ago

mudrd8mz commented 7 years ago

If I specify the topics with HTML tags (such as <h1>Topic 1</h1>, <h1>Topic 2</h1> etc) and use the same for the list of knowledge questions, the behaviour is inconsistent.

Knowledge questions seem to be handled differently from topics.
Things look differently in the preview and then later in actual usage.

Maybe you want to simply consider all these fields as plain text fields and always use the s() function when printing them via PHP, and the appropriate way to handle them via JS.

jkonert commented 7 years ago

Tag usage in topics/knowledge leads to empty fields in questionnaire. Better behaviour: Convert all tags to HTML safe representation.

rroepke commented 7 years ago

Maybe you can find the thing to change in settings_functions.js such that in the knowledge-preview in the settings possible HTML is displayed correctly. For topics, this already is implemented but I couldn't figure out how