search

moodmosaic / Fare

Port of Java dk.brics.automaton and xeger, mostly used for generating strings that match a specific regular expression.
http://www.brics.dk/automaton/
MIT License
182 stars 43 forks source link

Strong Name Signing #25

Closed DanyO closed 6 years ago

DanyO commented 7 years ago

Would it be possible to "Strong Name Sign" the assemblies in this NuGet package?

Referencing/Using this package in a strongly-named assembly results in the following error at runtime: Could not load file or assembly 'Fare, Version=1.0.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)

moodmosaic commented 7 years ago

Would it be possible to "Strong Name Sign" the assemblies in this NuGet package?

Perhaps, it would be possible, but wouldn't it be a breaking change to existing consumers of the .DLL?

JimiC commented 7 years ago

@DanyO Clone the repo and build it by signing it with your own key, assuming that the same dll is going to be used in all your projects. Then reference the signed dll to your project. I know that this is an extra step of maintenance from your side, but this way everyone gets what he wants and no breaking changes are introduced.

moodmosaic commented 7 years ago

To be clear, I'd happily sign the assemblies as long this doesn't break existing clients. — On a side note: I almost never found Strong-Named Assemblies that useful, and that's the reason why this one isn't signed (yet) also. Here's some useful notes by @adamralph on the subject.

moodmosaic commented 6 years ago

See https://github.com/AutoFixture/AutoFixture/pull/972#issuecomment-361206258.

A signed version of the assembly will be released as Fare.Signed next to the existing NuGet package. So there will be two NuGet packages:

I'll close this once the new NuGet package is pushed.

moodmosaic commented 6 years ago

/cc @zvirja