moodmosaic / Fare

Port of Java dk.brics.automaton and xeger, mostly used for generating strings that match a specific regular expression.
http://www.brics.dk/automaton/
MIT License
183 stars 43 forks source link

Build scripts should also run on Un*x operating systems #31

Open moodmosaic opened 6 years ago

moodmosaic commented 6 years ago

because right now I'm mostly on macOS High Sierra (10.13) and Ubuntu (16.04) and I can't easily run a build and push a new package on NuGet Gallery. #30, #21

zvirja commented 6 years ago

@moodmosaic Unfortunately, I don't have MacBook yet to test up the script there. That's why you need AppVeyor to run the build 😄

Do you want me to provide you with the latest artifacts (build locally) so you could proceed with the release? 😅

moodmosaic commented 6 years ago

Do you want me to provide you with the latest artifacts (build locally) so you could proceed with the release? 😅

Sure :laughing: I may not try them right now but I'm curious so I think I'll get to them soon. Thank you!

zvirja commented 6 years ago

@moodmosaic It seems that you performed some weird tagging, so now git describe is confused:

$ git describe --tags --long --abbrev=40 --first-parent --match=v*
warning: tag 'v1.0.5' is really 'v1.1.0' here
v1.0.5-0-ge10a97a90b3858ef08bd0b644976bfd3379ca3ad

It's showing v1.0.5 instead of v1.1.0. I found that it could happen if you based tag on other tag: https://stackoverflow.com/questions/14380053/renaming-git-tags-results-in-inconsistency.

Could you please fix the tags (probably, remove and push again), so that git describe command shows 1.1.0 instead?

Thanks 😉

moodmosaic commented 6 years ago

Yes, I did that (on the Stack Overflow answer).

I'll just delete that tag and re-tag it, in the next couple of hours hopefully.

Thank you for pointing this out.

zvirja commented 6 years ago

@moodmosaic Thanks! Let me know when you are ready. After that I'll trigger the build and attach the artifacts, so you could publish them 😉

zvirja commented 6 years ago

Just realized that actually I don't need to wait till you fix the tag to produce the build with valid version. Therefore, here the v1.1.0 release is: v1.1.0 Release artifacts.zip

moodmosaic commented 6 years ago

Tags should be all set now. I will push a new version on NuGet tomorrow.

moodmosaic commented 6 years ago

FWIW, I've just pushed Fare 1.1.0 on NuGet.

zvirja commented 6 years ago

@moodmosaic Awesome, thanks for notifying! 😉