search

moodmosaic / Fare

Port of Java dk.brics.automaton and xeger, mostly used for generating strings that match a specific regular expression.
http://www.brics.dk/automaton/
MIT License
182 stars 43 forks source link

Add Fare assembly signing #33

Closed zvirja closed 6 years ago

zvirja commented 6 years ago

Closes #25

Add signature to the Fare assembly.

P.S. To trigger the release, please add the tag with v2.0.0 name, run build and publish the artifact from the build\NuGetPackages\ folder.

moodmosaic commented 6 years ago

I will merge this and do a release as soon as I'm in front of a desktop OS :smiley:

zvirja commented 6 years ago

Thanks for the quick merge.

If you push a tag for v2.0.0, I could build the package and attach to comment. Just let me know if you need my help :relaxed:

moodmosaic commented 6 years ago

I just tagged and published Fare 2.0.0.

FWIW, I had to add a Version element in Fare.csproj so that dotnet pack can create a NuGet package with the right version.

zvirja commented 6 years ago

Thanks for pushing the package. :+1:

There is no need in adding the version explicitly. In the Fake build scripts I use Git tags to resolve the version. Therefore, after you create the v2.0.0 tag and run the build, the produced package should have the right version. That's the same approach we have in AutoFixture.

Could you please remove the version element and see whether it works? The added property might break the automatic versioning. :unamused:

moodmosaic commented 6 years ago

Oh, I totally forgot about the build scripts. I will remove it.

A sane .csproj and the dotnet command should eliminate those build scripts, eventually.