search

moodmosaic / Fare

Port of Java dk.brics.automaton and xeger, mostly used for generating strings that match a specific regular expression.
http://www.brics.dk/automaton/
MIT License
183 stars 43 forks source link

Remove Empty option handling to fix issue 32 #52

Closed jburnett closed 4 years ago

jburnett commented 5 years ago

The change in RegExp.cs fixes issue 32 by ignoring RegExpOptions.Empty during parsing. Added repo case to XegerTests.cs. I included the changes target framework I used on MacOS, but you can skip them & test w/.NET Fx and older netcore.

moodmosaic commented 5 years ago

Thank you! I'll try this in a few fairly sized, internal, codebases that make use of Fare and let you know whether this breaks something or not.

If all goes fine, this should be merged over the next few days and released on NuGet as well. :rocket:

jburnett commented 4 years ago

I'll create a new PR to make it easy.

moodmosaic commented 4 years ago

Sounds good! Thank you, @jburnett.