search

moody / Dejunk

Simple junk selling and destroying for WoW.
https://www.curseforge.com/wow/addons/dejunk
MIT License
10 stars 3 forks source link

[question/suggestion] The Looter ticker interval #212

Closed tflo closed 3 months ago

tflo commented 5 months ago

I had issues with the Looter not opening all lootable boxes, sometimes only one, and often boxes getting stuck in sort of a locked state, so that pressing the Looter key repeatedly became pointless.

I fiddled around with the minLatency parameter of the GetLatency function (which computes the effective interval for the ticker in looter.lua, line 73) and currently I’m playing with a value of 1.8 (original was 1).

My Looter works almost flawlessly now, i.e. almost always one press of my Looter key opens all boxes; only the very occasional box in locked state, but far less than before.

I think the big improvement became noticeable at around a value of 1.5, I added 0.3 as a safety margin.

I couldn't find a single looter-related issue on this page, so I guess it's just me? But I don't have any unusual server lag currently or since I started using Dejunk (and the GetLatency function is supposed to take that into account anyway).

I do the Shadowlands Covenant missions on ~15 toons at least once a day, so I have to deal with a lot of these lootable herb/ore crates (e.g. 184647). It's also possible that there's something special about these crates that makes them take longer to open or whatever...

moody commented 3 months ago

Yep, I've noticed that this functionality is a bit busted at times, especially with a lot of lootable items. There's likely a better solution than relying on some abstract amount of time between attempts to loot, but I haven't taken the time to dig more into it yet. It's difficult to test properly whenever I make a change to the behavior.

tflo commented 3 months ago

better solution than relying on some abstract amount of time

Yes, there are a whole bunch of loot-related events, like LOOT_CLOSED, LOOT_SLOT_CLEARED, LOOT_READY, and whatnot.

Probably one of these could be leveraged for a precise timing. But I'm not sure if these always fire reliably (which might be the cause of the occasional "loot locked" state of a box), and if someone is using one of these "fast loot" addons, the event flow is likely to get screwed up anyway.

BTW, I'm still playing with my 1.8 minLatency and still having good results – in my setup. You could also make the value user-settable.