Feature request: Food items, Potions?

[jsauerland]

Now that Warbound has changed the landscape of the game, I'm full-blown autolooting on every single character I have, which created a new issue for my use... Food, drinks, potions from all xpacs now have to be added to global inclusions, and they seem to not "stick" and reset often, makes sense if I re-install the addon. Is there a way to add checkbox to include crap food and potions? Might make raiders mad though if they accidently vendor a stack of flasks, 😆 🤣 they'd need to 'exclude' list them

[moody]

Can't remember if it's possible to differentiate between types of consumable items, I'll have to look into it.

At the very least, options to Include Consumable Items or Exclude Consumable Items are a possibility.

[jsauerland]

@moody I do have an idea that could work actually. If we had the ability to create item lists in notepad or text file, and import them into Dejunk, that honestly could work perfectly. Someone could then make a huge "this is crap" list of items like potions, food, etc from past expansions. I think this is a much cleaner option than dragging 50+ items on your character into global inclusions because you'd need to do that for every item one by one, and if you ever delete/reinstall addon, you could lose your entire global list. Is it feasible to have an import feature? I'd gladly start putting together a list of items and item IDs from past expansions that you'd virtually never need.

Here's a quick 1 min mockup in LUA for WOTLK potions. I'm not sure if this is helpful, sorry if it's not.

local junk_potions = {
    ["Runic Healing Injector"] = 41166,
    ["Indestructible Potion"] = 40093,
    ["Runic Mana Injector"] = 42545,
    ["Runic Mana Potion"] = 33448,
    ["Potion of Nightmares"] = 40081,
    ["Potion of Speed"] = 40211,
    ["Runic Healing Potion"] = 33447,
    ["Mighty Shadow Protection Potion"] = 40217,
    ["Resurgent Healing Potion"] = 39671,
    ["Noth's Special Brew"] = 39327,
    ["Crazy Alchemist's Potion"] = 40077,
    ["Icy Mana Potion"] = 40067,
    ["Endless Healing Potion"] = 43569,
    ["Endless Mana Potion"] = 43570,
    ["Murliver Oil"] = 38351,
    ["Potion of Wild Magic"] = 40212,
    ["Mighty Frost Protection Potion"] = 40215,
    ["Mighty Fire Protection Potion"] = 40214,
    ["Mighty Nature Protection Potion"] = 40216,
    ["Argent Healing Potion"] = 43531,
    ["Powerful Rejuvenation Potion"] = 40087,
    ["Mighty Arcane Protection Potion"] = 40213,
    ["Zort's Protective Elixir"] = 36770,
    ["Argent Mana Potion"] = 43530
}

[moody]

Import/Export for lists already exists:

But note that Dejunk isn't optimized for huge lists at the moment (say 1000+ items), due to the time it takes to load item data from the server. See #222.

[jsauerland]

@moody Awesome, I totally missed that button. The only thing I can possibly think of as a workaround to #222 is "lazy loading". Instead of the addon loading the entire batch of inclusions all at once, perhaps segmenting it. The way I understand how addons load is like people getting onto a train. 5000 people getting onto a train at the same time simply doesn't work, the door is too small. But loading it sequentially over time may work? For example, if user has 15000 items, maybe there's a way to segment this and load these over time. For example, load items 1-500 first. Then, load items 501-1000 and so on. Basically, chunking the data using some sort of for loop into smaller chunks, with reasonable delays between them.

If this isn't feasible, I totally understand that, just an idea. I loaded 1200 just now in my game and rebooted the game... Having zero issue so far 🤔