hazel-bunny
commented
1 month ago Build fails:
[ 16%] Building CXX object libappletdecoration/CMakeFiles/appletdecorationplugin.dir/appletdecorationplugin_autogen/mocs_compilation.cpp.o
In file included from /home/REDACTED/src/applet-window-buttons6/build/libappletdecoration/appletdecorationplugin_autogen/EWIEGA46WW/../../../../libappletdecoration/previewclient.h:18,
from /home/REDACTED/src/applet-window-buttons6/build/libappletdecoration/appletdecorationplugin_autogen/EWIEGA46WW/moc_previewclient.cpp:9,
from /home/REDACTED/src/applet-window-buttons6/build/libappletdecoration/appletdecorationplugin_autogen/mocs_compilation.cpp:12:
/home/REDACTED/src/applet-window-buttons6/build/libappletdecoration/config-decoration.h:1:3: error: invalid preprocessing directive #SPDX
1 | # SPDX-FileCopyrightText: 2018 Michail Vourlakos <mvourlakos@gmail.com>
| ^~~~
/home/REDACTED/src/applet-window-buttons6/build/libappletdecoration/config-decoration.h:2:3: error: invalid preprocessing directive #SPDX
2 | # SPDX-License-Identifier: GPL-2.0-or-later
| ^~~~
make[2]: *** [libappletdecoration/CMakeFiles/appletdecorationplugin.dir/build.make:94: libappletdecoration/CMakeFiles/appletdecorationplugin.dir/appletdecorationplugin_autogen/mocs_compilation.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:351: libappletdecoration/CMakeFiles/appletdecorationplugin.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
I added a setting to configure the KWin option BorderlessMaximizedWindwos, which makes sense, because its only real use case is given, when using this plasmoid. I added a new Behavior tab to the settings page, which uses Kirigami like the KDE stock plasmoids. The existing General page can not be converted to Kirigami Formlayout, because the Drag and Drop of the functionality of the rearrange buttons feature does not work then. For now I´d suggest to keep it as it is. (unlike Kirigami it is not responsive, when resizing the window) The licenses were converted with kde licensedigger to the recommended reuse compliant spdx format.