search

moodymudskipper / flow

View and Browse Code Using Flow Diagrams
https://moodymudskipper.github.io/flow/
Other
395 stars 26 forks source link

compact argument ? #12

Closed moodymudskipper closed 4 years ago

moodymudskipper commented 4 years ago

Original view was ambiguous as the following would have been represented the same way : 

library(funflow)
test <- function(x) {if(foo) stop() else bar}
test2 <- function(x) {if(foo) stop(); bar}
view_flow(test)

view_flow(test2)

Created on 2019-10-21 by the reprex package (v0.3.0)

Nevertheless they ARE equivalent, and we might want to see the simplified diagram.

The logic would have to be reworked a bit unfortunately because the original was failing in several corner cases, and the new one is easier to conceptualize.

Maybe the easiest way would be to build the chart with these end blocks and remove them in the end.

moodymudskipper commented 4 years ago

After a few months using it I never missed it, downgrading the priority and putting on hold

moodymudskipper commented 4 years ago

not that useful, we have enough options, closing

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.