search

moodymudskipper / flow

View and Browse Code Using Flow Diagrams
https://moodymudskipper.github.io/flow/
Other
395 stars 26 forks source link

Random ideas about redraw #48

Closed moodymudskipper closed 3 years ago

moodymudskipper commented 3 years ago

In flow_run(), we can't draw every step as it would often be really slow.

When browsing, it would be nice to have a way to refresh automatically, and we could do it, but it seems we can't turn it off when we exit the browsing.

so we use redraw() , and by default nothing is displayed. redraw(always = TRUE), once implemented, could redraw every step, but then we need to turn it off before getting out of the debugger.

Maybe redraw should have other arguments from flow_view, to choose what/how to draw, with the default being set by flow_run.

We could have a lazy binding triggering redraw() too, but as we don't have a distinct browsing environment it might be overwritten, which maybe is OK but I'm not super comfortable, and I don't know what character we'd use.

We can have an addin too.

I'm not really sure about the name redraw either, because we use it also to draw for the dirst time.

Maybe just draw ? It's shorter to type too.

This function should fail explicitly if called inappropriately.

moodymudskipper commented 3 years ago

After some researches, d and D are not common function names, the packages that use them see quite specific and never exceed 100 downloads a day by much.

snnR, hot.deck, Momocs, hydroGOF, BayesianFROC, brnn, HelpersMG, riskclustr

image

So I think it would be fair to use d as an active binding to another function, that we name flow_draw(), the latter can be called to provide arguments.

moodymudskipper commented 3 years ago

done

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.