search

moodymudskipper / flow

View and Browse Code Using Flow Diagrams
https://moodymudskipper.github.io/flow/
Other
395 stars 26 forks source link

Pretty printing of pipes #54

Closed whtns closed 3 years ago

whtns commented 3 years ago

This package is really cool! I'm sure you have a lot of priorities to juggle. A small request would be to make magrittr pipes print on separate lines. Maybe solved by using styler?

moodymudskipper commented 3 years ago

Thanks! Good point about the pipes, I haven't yet drawn many functions that used it.

It would make sense to use styler, i had opened this already : https://github.com/moodymudskipper/flow/issues/51 . I'm keeping this open to make sure pipes print ok once #51 is done.

moodymudskipper commented 3 years ago

@whtns Can you reinstall and tell me what you think ? I used {styler} with the default style. I also changed the default font to be monospace with the nomnoml engine, I had probems changing the font with the plantuml engine for some reason.

I think ultimately, you'll be able to use the style you want through an argument and/or options.

fun <- function() {
  cars %>%
    filter(speed > 5) %>%
    mutate(a == "a")
}
flow::flow_view(fun)

Created on 2020-09-25 by the reprex package (v0.3.0)

whtns commented 3 years ago

Wow, quick turnaround. Not familiar with the optional styles in styler but default works great for me!

moodymudskipper commented 3 years ago

great! I'll close this then, and will keep the linked issue open until i'm happy enough with the solution. Thanks for the issue.

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.