some characters in special comments make flow_view fail

[moodymudskipper]

works <- function() {
  ## comment
  foo
}

fails <- function() {
  ## comment[
  foo
}
flow::flow_view(works, prefix = "##")

flow::flow_view(fails, prefix = "##")

^{Created on 2020-09-29 by the reprex package (v0.3.0)}

[moodymudskipper]

data$nodes$label wasn't escaped in build_nomnoml_code().

[moodymudskipper]

additionally :

works <- function() {
  ## comment
  "foo[]"
  foo[]
}

fails <- function() {
  ## "comment"
  foo
}
flow_data(works, prefix = "##")
flow_data(fails, prefix = "##")

[moodymudskipper]

had to escape " in add_comment_calls

[moodymudskipper]

another weird issue in regular comments :

works <-
  function() {
    if(cond1) {
      # ,
      if(cond2) {
        foo
      }
    }
  }

fails1 <-
  function() {
    if(cond1) {
      # ,
      # com
      if(cond2) {
        foo
      }
    }
  }

fails2 <-
  function() {
    if(cond1) {
      # ,
      ## com
      if(cond2) {
        foo
      }
    }
  }

flow_data(works, prefix = "##")
flow_data(fails1, prefix = "##")
flow_data(fails2, prefix = "##")

[moodymudskipper]

seems to be solved by other fixes, I see nothing wrong with current local version

[github-actions[bot]]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.