zooming/vector graphics?

[MichaelChirico]

Have some issues seeing details on our more complicated functions (e.g. data.table::foverlaps & data.table:::dcast.data.table)

Would be great to zoom!

[moodymudskipper]

You might want to try different browsers. There's a button in Rstudio to open in your default browser and you can copy the url to a different browser. In my case Internet explorer worked than chrome. Can you please test on the browsers you have and report ?

There is actually a zoom argument that you can play with (pass through the ...) but I think its effect depends on browser too.

I think it would really make sense to be able to chunk big charts, especially those that take a lot of horizontal space, but I need to figure out the heuristics, parameters, and how to display it.

[MichaelChirico]

Hmm I was looking for a button to open in browser but I didn't get anywhere:

Export allows me to save as a webpage but (in Chrome/Safari at least) that page didn't offer any zoom either :\

[moodymudskipper]

Open in browser is the last icon on the right in your last image. Though I guess it won't help you much here.

[moodymudskipper]

Maybe I can also save it through code to a big svg image

[MichaelChirico]

Oh, I see, thanks. The hover-over said "Open in new window" which threw me off. For Shiny e.g. it explicitly says "Open in browser".

Again, not sure the implementation complexity, but I've found PDF more satisfying for this type of thing in terms of output.

[moodymudskipper]

Can you update the package and try this ?

tf_foverlaps <- tempfile(fileext = ".png")
tf_dcast <- tempfile(fileext = ".png")
view_flow(data.table::foverlaps, png = tf_foverlaps)
view_flow(data.table:::dcast.data.table, png = tf_foverlaps)
browseURL(tf_foverlaps)
browseURL(tf_dcast)

Still no luck with [.data.table, it doesn't error but doesn't write the file either, not sure if the issue comes from nomnoml, htmlwidgets or webshot, or me :), possibly a combination.

[MichaelChirico]

Nice! looking great

PS heads up that this one makes a suggested system dependency binding:

PhantomJS not found. You can install it with webshot::install_phantomjs(). If it is installed, please make sure the phantomjs executable can be found via the PATH variable.

[moodymudskipper]

Do you suggest I should do something to deal with this better ? If so, what should I do ?

[moodymudskipper]

splitting the chart has its own issue : https://github.com/moodymudskipper/funflow/issues/10

[MichaelChirico]

Do you suggest I should do something to deal with this better

No, it's just an FYI. The error message is quite helpful already.

[moodymudskipper]

foverlaps doesn't display right anymore because of https://github.com/moodymudskipper/funflow/issues/11

i.e. some if calls, and the function itself, never reach their end because there are return() or stop() calls at the end of both yes and no branches.

I think it shows the truth however, only polluted by some additional "end" blocks.

[moodymudskipper]

I don't think I can do much better than this about zooming but keeping this open until :

• documentation is good enough so users can find a satisfying way to see their chart
• we decide if a function/parameter should do tf <- tempfile(fileext = ".png"); view_flow(fun, png = tf); browseURL(tf) and how
• I go around complaining to all possible package maintainers about zoom and why big charts don't work.

[moodymudskipper]

We have the options zoom, height and width that are forwarded to nomnoml, and nomnoml can also in principle prints to svg but I can't get any of those to work, at least they don't change things for the better.

A range argument to the function flow_view (a rework of view_flow, which will disappear) has a range argument allowing to choose a starting and finishing block.

for instance flow_view(data.table::foverlaps, range = 17:36)

or flow_html(data.table::foverlaps, range = 17:36) to create an html page

opening several of them makes it convenient to examine the logic of the function.

But still it's some work to determine the cutpoints.

We can do better by :

• computing the y coordinate of every block from our data$nodes and data$edges data frames
• singling out blocks that are unique at their y coord
• propose handy cutpoints for long functions
• the range arg is renamed to cutpoints and is a numeric vector of those, 2 cutpoints is one interval, etc
• We can copy the proposed cutpoints to the cutpoints arg, and several views will be printed (or several html files produced etc)

This way even a huge function could be split without much manual tweaking, and be readable right away

[moodymudskipper]

@MichaelChirico I believe that now we have good ways to zoom. A range argument allows you to focus on some part, one can easily export in different formats (including html containing svg, to adress the vector graphics query, by setting svg=TRUE).

Using flow_run with trim = TRUE can also help.

It might be improved further later but closing for now.

[github-actions[bot]]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.