moodymudskipper / flow

View and Browse Code Using Flow Diagrams
https://moodymudskipper.github.io/flow/
Other
395 stars 26 forks source link

`edit` arg to cover latest feature requests + trim #83

Closed moodymudskipper closed 2 years ago

moodymudskipper commented 2 years ago

We might have too many arguments and it gets confusing, maybe we should have an edit arg:

flow_view_deps(fun, edit = list(trim = "fun1", promote = "pkg::fun2", demote = "fun3", hide = "fun4"))

or if we switch it around:

flow_view_deps(fun, edit = c(fun1 = "trim", "pkg::fun2" = "promote", fun3 = "demote", fun4 = "hide"))

Probably 1st one is better.

This list might be reused for different calls, so let's not fail if function doesn't exist, just ignore.

moodymudskipper commented 2 years ago

4 args is ok, no need to group those

github-actions[bot] commented 1 year ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.