search

moodymudskipper / flow

View and Browse Code Using Flow Diagrams
https://moodymudskipper.github.io/flow/
Other
395 stars 26 forks source link

flow_test() doesn't work right when tests fail! #89

Closed moodymudskipper closed 2 years ago

moodymudskipper commented 2 years ago

I'm pretty sure I had tested this in the past, I think this might be due to https://github.com/r-lib/testthat/issues/1430

test_that() can now fail when used interractively, so we need to wrap call into try(, silent = TRUE)

moodymudskipper commented 2 years ago

I'd rather not have checks to have the code depend on which version of {testthat} is installed so I'll just assume the last version is installed and it will work like this forever. This feature cannot be easily tested with CI so it's annoying. I don't know a clear way around it.

moodymudskipper commented 2 years ago

hopefully fixed by https://github.com/moodymudskipper/flow/commit/a982c3ceee88c5c336c2f68119587d42e42a2cec

github-actions[bot] commented 1 year ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.