moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

improved by using expressions ? #10

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

again something that would work only for eat because it assumes asymmetry.

eat(x,y, by = c(colx = toupper(coly))

it would require NSE of course, maybe it's misleading to use c, a temp column would be created for the join and deleted in the end. Using := we could use it on both sides and integrate in every join, however if we need to get rid of original cols we need to do it like this :

eat(x,y, -coly, by = c(colx = toupper(coly))

Taking into consideration conflict edge cases. And make sure that the temp joining columns are computed before columns are removed