moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

Structure the safe_* function definition #17

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

No more copy pastes, already posed issues and time consuming each time.

A safe_* function is wrapped around its dplyr counterpart with exactly the same code, and always has the same formals + a fixed list. So let's just have make_safe() and safe_left_join = make_safe(dplyr::left_join)

We need also to get rid of the dots and add the na_matches with an exception for nest_join. So make_safe should have add_na_matches = TRUE by default

moodymudskipper commented 5 years ago

done