search

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

Eat a list of tables #19

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

So users don't have to do complex Reduce calls. Better to make eat a generic.

moodymudskipper commented 5 years ago

This could be supported by all functions

moodymudskipper commented 5 years ago

It cannot be a generic if it's the 2nd argument though, should we have a single one ?

It feels to me now that x should be the unit of the reduce. In the worst case we would have `eat(L[[1]], L[[-1]]).

Test is.list(y) && !is.data.frame(y) and apply recursively

The list could be named and these names would override prefix, so we don't have to do weird substitute magic as implied by https://github.com/moodymudskipper/safejoin/issues/20 . If we want flexibility we could have this name sent as .y to prefix. So by default when not providing prefix we have prefix = ~paste0(~.y, "_", .x)

moodymudskipper commented 5 years ago

done