search

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

urgent: X and Y not recognized #26

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

must urgently recognize what's up with this : 

sub_df1 <- structure(list(database = "CLO, ArrayExpress, ArrayExpress, ATCC, BCRJ, BioSample, CCLE, ChEMBL-Cells, ChEMBL-Targets, Cosmic, Cosmic, Cosmic, Cosmic-CLP, GDSC, GEO, GEO, GEO, IGRhCellID, LINCS_LDP, Wikidata", database_accession = "CLO_0009006, E-MTAB-2770, E-MTAB-3610, CRL-7724, 0337, SAMN03471142, SH4_SKIN, CHEMBL3308177, CHEMBL2366309, 687440, 909713, 2159447, 909713, 909713, GSM887568, GSM888651, GSM1670420, SH4, LCL-1280, Q54953204"), .Names = c("database", "database_accession"), row.names = 2L, class = "data.frame")
sub_df2 <- structure(list(database_accession = "SH4_SKIN", G1 = -1.907138, G2 = -7.617305, G3 = -3.750553, G4 = 2.615004, G5 = 9.751557), .Names = c("database_accession", "G1", "G2", "G3", "G4", "G5"), row.names = 101L, class = "data.frame")
safe_full_join(sub_df1, sub_df2, by= ~stringr::str_detect(
  X("database_accession"),
  Y("database_accession")),
  check="")

I don't know how tests were passed but X and Y are not recognized here as they are called from fuzzyjoin, this needs to be addressed asap, exporting them will work but it doesn't make sense to have those exported

moodymudskipper commented 5 years ago

X & Y were exported, documented, and fail explicitly when called from global env