copy fuzzy_join function inside our package

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks

GNU General Public License v3.0

42 stars 7 forks source link

Closed moodymudskipper closed 3 years ago

moodymudskipper commented 5 years ago

We're using only function fuzzy_join from package fuzzyjoin and it's not dependent on other fuzzyjoin functions.

This way we can :

Implement best join
correct the strange behavior it has for undocumented features (that we sort out externally at the time)
Use X and Y with less hacking, and have them not exported
Implement optimizations
Have one less dependency

Make sure to credit David Robinson properly.

moodymudskipper commented 5 years ago

[x] copy function code
[x] change calls fuzzyjoin::fuzzy_join to just fuzzy_join
[ ] credit David
[ ] change docs so it doesn't say it's a wrapper around fuzzyjoin but says it's inspired or partially a fork etc
[ ] unexport X & Y

moodymudskipper commented 5 years ago

common_by and %||% had to be copied as well.

moodymudskipper commented 3 years ago

I refactored fuzzyjoin and borrowed just the needed part in powerjoin