moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

edge case with duplicate cols when by is different on two sides #3

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago
x <- data.frame(a=1,b=1)
y <- data.frame(a=1,c=1)
eat(x,y, .by=c(a="c"), .check = "C")
#   a b a.y
# 1 1 1   1

This shouldn't work, and it works silently, not safe. We apply our standard conflict function.

moodymudskipper commented 5 years ago

done