"patch" doesn't work reliably

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks

GNU General Public License v3.0

42 stars 7 forks source link

Closed moodymudskipper closed 4 years ago

moodymudskipper commented 5 years ago

investigate, add tests

moodymudskipper commented 4 years ago

It was broken because dplyr::mutate_at(res,c(dummy_col,temp_cols), ~NULL) is not accepted anymore, ~NULL is not a legal formula for some reason.

We remove columns more idomatically using select(res, -one_of(dummy_col, temp_cols))