moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

.at parameter to position eaten columns ? #5

Closed moodymudskipper closed 3 years ago

moodymudskipper commented 5 years ago

just makes sense in eat I think, if we stay consistent with the idea that no side is "special" in regular joins.

moodymudskipper commented 5 years ago

Maybe rather use .after ?, it's the same but + 1, we should never need to insert columns at the first place and I think when we we join we rarely care about adding a column before a give one ? I might be wrong.

Maybe it would even be some things like .after = starts_with("P") and in that case it will be after the LAST column starting with "P"

moodymudskipper commented 5 years ago

not sure how useful it really is