search

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks
GNU General Public License v3.0
42 stars 7 forks source link

could we support negative indices in eat ? #6

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

they don't trigger errors but don't give the result we might expect

moodymudskipper commented 5 years ago

It's just a matter of turning dplyr::select(y, !!!by_y_syms, ...) into dplyr::select(y, ..., !!!by_y_syms).

It places the by columns after but anyway y's by columns are never kept.

moodymudskipper commented 5 years ago

Done, we just have to add a test with "d" and an example in the vignette.

moodymudskipper commented 5 years ago

done