problem with `mutate_at(x,col, ~NULL)` in `resolve_conflicts()`

moodymudskipper / safejoin

Wrappers around dplyr functions to join safely using various checks

GNU General Public License v3.0

42 stars 7 forks source link

Closed moodymudskipper closed 5 years ago

moodymudskipper commented 5 years ago

Seems like it doesn't work with older versions of dplyr, should be changed.

Also definition of temp_cols should be below the loop, not inside (now it's computed several times)

moodymudskipper commented 5 years ago

just use res[temp_cols] <- NULL, much simpler

moodymudskipper commented 5 years ago

done, makebe sure to pull modified project at home

moodymudskipper commented 5 years ago

done