search

moodyydoom / pokemon-randomiser

Automatically exported from code.google.com/p/pokemon-randomiser
0 stars 0 forks source link

ROM type detection fails #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The ROM header is read using FileReader, which is supposed to be used for 
reading character streams, not raw binary data. In addition, when reading 
binary data, it should be read as byte[], not char[], to avoid conversion done 
by Java internally that will mess up offsets by converting more than one byte 
into exactly one char.

See here for a patch to fix the problem: https://gist.github.com/3892578

Original issue reported on code.google.com by oddega...@posteo.org on 15 Oct 2012 at 2:04

GoogleCodeExporter commented 8 years ago 
Fixed in version 1.2.3.  
Thanks for the patch.

Original comment by pateandrew@gmail.com on 16 Dec 2012 at 4:07